Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused PgLocks class #120

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Remove unused PgLocks class #120

merged 1 commit into from
Sep 1, 2020

Conversation

gadimbaylisahil
Copy link
Contributor

@gadimbaylisahil gadimbaylisahil commented Sep 1, 2020

As title says

#121

@bensheldon
Copy link
Owner

Thanks! I'll merge this.

Also, you don't have to open an issue before you make a PR. And if you do, please use "Closes #number" in the PR so a linked Issue is closed automatically. 👍

@bensheldon bensheldon merged commit 2952c99 into bensheldon:main Sep 1, 2020
@gadimbaylisahil
Copy link
Contributor Author

Thanks! I'll merge this.

Also, you don't have to open an issue before you make a PR. And if you do, please use "Closes #number" in the PR so a linked Issue is closed automatically. +1

Should I add Closes #number in PR title or comments?

@bensheldon
Copy link
Owner

Please leave the reference in the description/comment.

And if you're making the PR in reference to another comment or Issue, even if just relatedly, drop a link to that too.

@gadimbaylisahil gadimbaylisahil deleted the fix/remove-unused-class-pg_locks branch September 1, 2020 16:56
@bensheldon bensheldon added the refactor Code changes that do not introduce new features label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not introduce new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants