Re-add footer with GoodJob version number #1201
Conversation
Add secondary navbar with last updated data.
Render secondary navbar below navbar.
Add secondary_navbar translation.
Add border-bottom, Remove footer class, change the html element to a better context, change id and data live poll region context. This is used in live_poll.js only. LivePoll.js take each data attribute to replace in the same place with new dom elements, so there is no risk to brake another page dynamism.
add secondary_navbar to all translations.
Not sure about what to include in footer? What about author name and link to github repository?
remove footer translation since it is simple author name and github. This is so to avoid needs of adding all translation.
# Conflicts: # app/views/good_job/shared/_footer.erb # app/views/good_job/shared/_secondary_navbar.erb # app/views/layouts/good_job/application.html.erb # config/locales/de.yml # config/locales/en.yml # config/locales/es.yml # config/locales/fr.yml # config/locales/ja.yml # config/locales/nl.yml # config/locales/ru.yml # config/locales/tr.yml # config/locales/uk.yml
|
I think footer can be removed at all then to release some space. |
|
Was this merge intentional? @bensheldon ? I can rebase into new main and then push again mine to yours. The idea behind changing the translation files keys it to keep the context updated. Please, let me know what to do next. Happy new year! |
|
@Pauloparakleto yep, sorry. I realized there was a duplicate feature in #1204, but I liked your retaining of the footer so I wanted to preserve that. |
bensheldon
changed the title
Thanks again, I have used this project a lot in my open source project. Contributing to yours has been part of my new job. |
Yay! I love to hear that. I'm really glad that GoodJob has been of service! Also I really appreciate the contributions 🙇🏻 |
close #1183
Based on this discussion, it was suggested by @simi as an initial idea moving the footer message to the top.
@bensheldon About been not sure what to include in footer, I think should be useful author name(with link to author) and github(with link to goodjob repository).