-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment label to navbar #1206
Add environment label to navbar #1206
Conversation
@bensheldon This is so usefull for a first version. Sometimes I place development and production together when monitoring the jobs. It can avoid lot of mistakes. |
I like this in principle, but I think the visual design of it needs some
|
@bensheldon i have pushed the changes you requested. |
@sparshalc may you please provide the pictures how it is after the updates, thank you a lot. I am eager to use the new version :D |
As per @bensheldon 's suggestion, I have incorporated the environment details into the primary navbar. |
I made a few tweaks so it's always visible regardless of viewport. I also swapped it to a globe because ChatGPT made a very convincing, though possibly ridiculous, argument 😆
|
I just saw this change come through in the dependabot changelog. Nice one! Would you be open to having a way to set/override the source of this label? In our setup, we have 3 Rails envs: development, test, and release. The release env itself runs in different stages, namely: edge, demo, production. For the one or two places in our app where we want to know what actual stage it's running in, we read the What about a config option to allow customising this that would continue to fall-back to config.good_job.environment_label = ->() { ENV.fetch("APP_ENV") { Rails.env } } Just as I was about to submit this, I saw this comment from the linked issue actually recommended making it customisable. This was a nice approach. |
This pr addressed #1116 . I have updated the relevant code to ensure that the environment label is visible in the secondary navbar.