Load metrics for top nav asynchronously #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
requested changes
Feb 9, 2024
| jobs_count = number_to_human(GoodJob::Job.count) | ||
| batches_count = number_to_human(GoodJob::BatchRecord.migrated? ? GoodJob::BatchRecord.all.size : 0) | ||
| cron_entries_count = GoodJob::CronEntry.all.size | ||
| render json: { jobsCount: jobs_count, batchesCount: batches_count, cronEntriesCount: cron_entries_count } |
There was a problem hiding this comment.
nice and simple 👍🏻
This is a personal preference: I'd like these values to be snake_case instead of camelCase
| @@ -0,0 +1,19 @@ | |||
| import { Controller } from "stimulus" | |||
| export default class extends Controller { | |||
There was a problem hiding this comment.
I'd like this Stimulus controller to be written generically as like "AsyncValuesController". I'm imagining,
It would take a url value that corresponded to the value being fetched.
It would have value targets with a key attribute whose value corresponded to a key in the fetched json.
The resulting HTML would look something like this:
<div data-controller="async-values" data-async-values-url="...">
<div data-async-values-target="value" data-async-values-key="jobs_count"></div>
</div>
binarygit
force-pushed
the
load-metrics-for-top-nav-async
branch
from
697fc64
to
4776ceb
Compare
|
@bensheldon I apologize for taking sooooo long to make these changes. Past month's been a little of a roller coaster. Could you look at the changes and let me know what you think? |
…ss count too with color
bensheldon
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses #1057.
I have only worked on the metrics in the top nav like you mention in the comment in that issue. I am looking into loading the metrics in the tab navs async too, but I'll wait until you review this implementation.