Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Engine scaffold #125

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add initial Engine scaffold #125

merged 2 commits into from
Sep 2, 2020

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Sep 1, 2020

Does nothing useful except set up a mountable engine and system tests.

Connects to #23

  • Creates a separate isolated GoodJob::Engine class so that it is not eagerloaded and GoodJob can be used in situations where loading all of Rails is not necessary.

For installation:

  • Add require "good_job/engine" to config/application.rb beneath Rails
  • Mount the engine: mount GoodJob::Engine => "/good_job"

New Assets:

  • Bootstrap Reboot (MIT License)
  • Chartist.js (MIT License)

Note: The current state of asset compilation and gems is up in the air. Given this is a private dashboard, I made the decision to inline the assets into the HTML.

@bensheldon bensheldon merged commit ba8006f into main Sep 2, 2020
@bensheldon bensheldon deleted the engine branch September 2, 2020 14:38
@bensheldon bensheldon added the refactor Code changes that do not introduce new features label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not introduce new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant