Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Active Record connection changes on Rails head #1259

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix Active Record connection changes on Rails head #1259

merged 2 commits into from
Feb 21, 2024

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Feb 20, 2024 •
edited
Loading

Fixes changes on Rails HEAD related to rails/rails#51083

  • need to change GoodJob::AssignableConnection#with_connection because it now shadows a newly introduced method in Active Record of the same name
  • There is a bug in connection checkout

@bensheldon bensheldon changed the title Fix test runner database connection name on Rails head Fix Active Record connection changes name on Rails head Feb 21, 2024
@bensheldon bensheldon changed the title Fix Active Record connection changes name on Rails head Fix Active Record connection changes on Rails head Feb 21, 2024
@bensheldon bensheldon marked this pull request as ready for review February 21, 2024 02:47
@bensheldon bensheldon merged commit 019b5b6 into main Feb 21, 2024
20 checks passed
@bensheldon bensheldon deleted the fix_application_name branch February 21, 2024 02:47
@bensheldon bensheldon mentioned this pull request Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bensheldon