Implement throttling options in concurrency extension #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marckohlbrugge Thank you so much for opening this! I'd like to make some tweaks to the interface for throttling. I can push those up and also fixup any of the other lint warnings. |
# Conflicts: # lib/good_job.rb # sorbet/tapioca/require.rb
|
I really like this! I combined your throttle extension into the existing Concurrency extension. I also discovered that Rail's TimeHelpers don't work the way I expected, so I replaced them with Timecop:
I realize that Throttling isn't quite the same as Concurrency, but there was so much overlap in functionality when reusing the keys and all I figured it made sense to combine. |
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial MVP for at throttling extension. I'm not sure I'm qualified to take it the whole way as my understanding of Good Job and some of its architecture is very limited. But creating this PR by @bensheldon's request so we have a place to discuss this particular code.
Credit goes to Ben for his gist where this code is based on: https://gist.github.com/bensheldon/89f772eb8f55058e87959b008e5081b9
Also see #315 #1198