Ensure job execution Advisory Lock query uses bind parameters #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
to_sql when generating materialized CTE; use Arel InfixOperation instead
bensheldon
force-pushed
the
bind_params
branch
2 times, most recently
from
d334fc6
to
3184012
Compare
bensheldon
changed the title
to_sql when generating materialized CTE; use Arel InfixOperation insteadto_sql when generating materialized CTE; use Arel UnaryOperation instead
bensheldon
changed the title
to_sql when generating materialized CTE; use Arel UnaryOperation instead
bensheldon
commented
Mar 21, 2024
| messages << message | ||
| end | ||
| model_class.where(priority: 99).order(priority: :desc).advisory_lock.to_a | ||
| expect(messages.first).to match(/WHERE "good_jobs"."priority" = (\$1|\?)/) |
There was a problem hiding this comment.
This could be improved by walking the Arel directly:
rails/rails@ecec50d#diff-3b43a67ee0006a80ddf7c8b7eb5f6cdfb8b3cfa1a6ef2c65f2b5c70b75736a2bR23-R29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_sqlwhen generating materialized CTE; use Arel UnaryOperation insteadArel::Nodes::BindParaminstead of a Time value directly