Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ActionMailer Job class, to match the default #130

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Update ActionMailer Job class, to match the default #130

merged 2 commits into from
Sep 9, 2020

Conversation

morgoth
Copy link
Collaborator

@morgoth morgoth commented Sep 7, 2020

bensheldon
bensheldon approved these changes Sep 9, 2020
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgoth Thank you for this update and correction!

I initially overlooked the mention of ActionMailer::MailDeliveryJob's previous name and suggest frontloading that information.

README.md Outdated Show resolved Hide resolved
@morgoth @bensheldon
Update README.md
1195d77 
Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com>
@bensheldon bensheldon merged commit b8320b2 into bensheldon:main Sep 9, 2020
@bensheldon
Copy link
Owner

@morgoth thank you for this correction to the Readme! 🙏

@bensheldon bensheldon added the documentation Improvements or additions to documentation label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgoth @bensheldon