-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store error backtraces on discrete executions #1325
Conversation
5907c5f
to
977fde1
Compare
977fde1
to
c76aac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome and super clean 👍🏻
Would you want to also render this out into the Dashboard view too in this PR?
Otherwise I have one tiny suggestion, and the test that fails is a flake, so this looks awesome 🎉
Co-authored-by: Ben Sheldon [he/him] <bensheldon@github.com>
Thanks for the swift review !
You can already kinda see it in the details of an execution in the I figured this is good enough for this PR and could be released as-is to provide some value, but if you have pointers on how you would like it to be displayed as a first class citizen, I'm glad to make a PR for it |
No sweat! I was poking around to form an opinion and just did it 😁 Thank you for working on this. It's great! |
This is pretty neat, thanks for working on this👍 If I am understanding this corretly, the cleaned backtrace will be saved and only the first frame displayed, is that correct? There have been several occasions where my application backtrace didn't include the full context, for one or another reason. Would it make sense to store the full backtrace and format only on display? I'm thinking of something like how Rails displays errors in development. Edit: openend #1328 |
Closes #1162