Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store error backtraces on discrete executions #1325

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

Intrepidd
Copy link
Contributor

@Intrepidd Intrepidd commented Apr 17, 2024

Closes #1162

Screenshot 2024-04-18 at 5 43 32 PM

@Intrepidd Intrepidd force-pushed the store-backtraces branch 2 times, most recently from 5907c5f to 977fde1 Compare April 17, 2024 09:55
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and super clean 👍🏻

Would you want to also render this out into the Dashboard view too in this PR?

Otherwise I have one tiny suggestion, and the test that fails is a flake, so this looks awesome 🎉

app/models/good_job/execution.rb Outdated Show resolved Hide resolved
Co-authored-by: Ben Sheldon [he/him] <bensheldon@github.com>
@Intrepidd
Copy link
Contributor Author

Thanks for the swift review !

Would you want to also render this out into the Dashboard view too in this PR?

You can already kinda see it in the details of an execution in the _good_job_execution key.

I figured this is good enough for this PR and could be released as-is to provide some value, but if you have pointers on how you would like it to be displayed as a first class citizen, I'm glad to make a PR for it

@bensheldon bensheldon added the enhancement New feature or request label Apr 19, 2024
@bensheldon
Copy link
Owner

No sweat! I was poking around to form an opinion and just did it 😁

Thank you for working on this. It's great!

@bensheldon bensheldon merged commit c0585ac into bensheldon:main Apr 19, 2024
21 checks passed
@Earlopain
Copy link
Collaborator

Earlopain commented Apr 19, 2024

This is pretty neat, thanks for working on this👍

If I am understanding this corretly, the cleaned backtrace will be saved and only the first frame displayed, is that correct? There have been several occasions where my application backtrace didn't include the full context, for one or another reason.

Would it make sense to store the full backtrace and format only on display? I'm thinking of something like how Rails displays errors in development. Edit: openend #1328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Storing backtrace in database?
3 participants