Fix a rails 6.1 deprecation warning for the duration attribute #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` DEPRECATION WARNING: The behavior of the `:interval` type will be changing in Rails 7.0 to return an `ActiveSupport::Duration` object. If you'd like to keep the old behavior, you can add this line to GoodJob::Execution model: attribute :duration, :string If you'd like the new behavior today, you can add this line: attribute :duration, :interval (called from block (3 levels) in perform at /home/runner/work/good_job/good_job/app/models/good_job/base_execution.rb:440) ```
Earlopain
force-pushed
the
duration-rails-6.1-deprecation
branch
from
0e7f7e8
to
e314e9c
Compare
|
I tried making specs fail to verify but I believe this is throwing a wrench into that: The deprecation is gone from the system tests though: https://github.com/bensheldon/good_job/actions/runs/9843564859/job/27175035831 vs https://github.com/bensheldon/good_job/actions/runs/9843820235/job/27175887019 so I believe this is fine |
|
Thank you 🎉 |
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a thing on Rails 6.1, I noticed this in the CI output for the system tests. It doesn't seem to terribly matter right now if it is returned as a string or interval but I don't think this distinction was intended.