Redefine Batch#finished_at to mean all callback jobs have finished too; add Batch#jobs_finished_at to allow not deleting batches until all their callback jobs complete
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
fix-batch-deletion
branch
4 times, most recently
from
70db1e4
to
a311e1e
Compare
bensheldon
commented
Aug 8, 2024
app/models/good_job/job.rb
Outdated
| @@ -761,6 +762,7 @@ def reset_batch_values(&block) | |||
|
|
|||
| def continue_discard_or_finish_batch | |||
| batch._continue_discard_or_finish(self) if batch.present? | |||
| callback_batch._continue_discard_or_finish(self) if callback_batch.present? | |||
There was a problem hiding this comment.
This shouldn't pass the job. If the job is a callback_job, it shouldn't have the ability to discard the batch.
bensheldon
force-pushed
the
fix-batch-deletion
branch
2 times, most recently
from
d6bc6ec
to
cb47fd2
Compare
Connects to #1387 Add logic to delete batches only after their callback jobs have completed.
bensheldon
force-pushed
the
fix-batch-deletion
branch
from
cb47fd2
to
4b5d828
Compare
bensheldon
changed the title
Batch#jobs_finished_at to allow not deleting batches until all their callback jobs complete
bensheldon
changed the title
Batch#jobs_finished_at to allow not deleting batches until all their callback jobs completeBatch#finished_at to mean all callback jobs have finished too; add Batch#jobs_finished_at to allow not deleting batches until all their callback jobs complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #1387
Add logic to delete batches only after their callback jobs have completed.