Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure before actions run on root route #1482

Merged

Commits on Sep 9, 2024

  1. Ensure before actions run on root route

    When using the recommended method for injecting a before filter into GoodJob the initial root route ignores that filter. In cases where someone is using that before filter to apply security they may want to return a non-301 response code for users who don't pass the authentication check.
    
    For example someone may want to obfuscate that they're using GoodJob by returning a 404 from all GoodJob routes if the user is not logged in. Before this change users would receive the redirect from the root route, then get the 404, essentially "leaking" that the site is running GoodJob.
    ebiven committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    397f1a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add query params to root route redirect.

    Live polling relies on a query string param with hits the root route. Ensure this param survives the redirect.
    ebiven committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ef4f065 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    ea3db49 View commit details
    Browse the repository at this point in the history