Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GoodJob::Setting duplicate keys #1498

Conversation

mohammednasser-32
Copy link
Contributor

fix #1490

The problem was that key is received as a symbol, while the settings array store the value in the database as strings, so

["heartbeat_schedules"].includes?(:heartbeat_schedules)
false

so we need to convert the key to string first

I also refactored cron_key_enabled test to be consisten with cron_key_disabled test

@bensheldon
Copy link
Owner

@mohammednasser-32 thank you! I just had to fix CI on main. I'm going to let CI run through (I feel confident it will be green) and I'll merge this.

@mohammednasser-32
Copy link
Contributor Author

@bensheldon Thank you! 🙏

@bensheldon bensheldon added the bug Something isn't working label Oct 8, 2024
@bensheldon bensheldon merged commit 194fc80 into bensheldon:main Oct 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Multiple same values in cron_keys_disabled, cron_keys_enabled in good_job_settings table
2 participants