Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge color for running jobs #1525

Merged

Conversation

Wittiest
Copy link
Contributor

Problem

When a job is running and has 1 attempt, the badge with Attempts has an error color
Screenshot 2024-10-14 at 7 45 38 AM

Solution Implementation

Screenshots

Running Jobs Tab

Screenshot 2024-10-17 at 9 09 15 PM

Batch Jobs Page

Screenshot 2024-10-17 at 9 12 43 PM

…ns; fix usage of nonexistent `:finished` status
@bensheldon
Copy link
Owner

I discovered that :finished isn't a valid Job#status but I was able to use finished?. I think I also was able to cover the logic a little better. I appreciate you raising this!!

@bensheldon bensheldon merged commit 839c037 into bensheldon:main Oct 23, 2024
25 checks passed
@bensheldon bensheldon added the bug Something isn't working label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Modify error color for Running tab when a job has 1 attempt
2 participants