Fix job ordering for Rails 6.1 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 6.1 it throws error: `Query method called with non-attribute argument(s): "COALESCE(scheduled_at, created_at) DESC"` It was printing a warning about it in Rails 6.0.
bensheldon
approved these changes
Dec 2, 2020
|
This has been released as |
|
I've added an appraisal for Rails 6.1 rc2 in #175 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 6.1 it throws error:
Query method called with non-attribute argument(s): "COALESCE(scheduled_at, created_at) DESC"It was printing a warning about it in Rails 6.0.
Sorry for not including spec - I had issues with setting up system specs.
BTW, Rails 6.1 is around the corner https://weblog.rubyonrails.org/2020/12/1/Rails-6-1-rc2-release/ so I guess we could extend appraisal to 6.1