Run tests with Rails default configuration to enable Zeitwerk #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoodJob requires Rails use the Zeitwerk autoloader (not Classic) for Rails 6.0+.
This PR ensures that that the test environment defaults to the configuration defaults for the version of Rails the test suit is being run against.
This was discovered because of a deadlock caused by isolating a single test that loads up a bunch of Scheduler threads at once. I think it's the same deadlock that causes CI tests to flakily time-out:
$ RBTRACE=1 bin/rspec spec/integration/scheduler_spec.rb:52
good_job/spec/integration/scheduler_spec.rb
Lines 52 to 57 in bed770d