Configure GoodJob via Rails.application.config instead of recommending GoodJob::Adapter.new
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing `GoodJob::Adapter.new`
bensheldon
force-pushed
the
rails_configuration
branch
from
9e8d668
to
13a059e
Compare
nnc
reviewed
Jan 16, 2021
README.md
Outdated
|
|
||
| # ...or all at once. | ||
| config.good_job = { | ||
| execution_mode = :async, |
There was a problem hiding this comment.
@bensheldon this should probably be execution_mode: :async?
Thanks for Good Job, btw. It's doing a Great job so far. 💯
There was a problem hiding this comment.
Thank you for catching this! 🙌
bensheldon
force-pushed
the
rails_configuration
branch
from
14310e0
to
7721035
Compare
…odJob::Job Necessary because there is a circular dependency in Rails 6.1 when ActiveJob initializes GoodJob, which references ActiveRecord, which tries to initialize ActiveJob (for the destroy associations async feature)
bensheldon
force-pushed
the
rails_configuration
branch
from
7721035
to
b89f186
Compare
This was referenced Jan 18, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a moderately significant change in recommended configuration.
The problem is that calling
GoodJob::Adapter.newwithinconfig/application.rborconfig/environments/*.rbcauses the Adapter to be instantiated too early in the Rails initialization process.This addresses #195, #89.
This also contains changes to
GoodJob::Performer, making it less generic and renaming it toGoodJob::JobPerformer. The intent is to to clearly delay references to GoodJob::Job. This is necessary because there is a circular dependency in Rails 6.1 when ActiveJob initializes GoodJob, which references ActiveRecord, which tries to initialize ActiveJob (for the destroy associations async feature).