Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Test Matrix with latest JRuby 9.2.17.0 #228

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Update GH Test Matrix with latest JRuby 9.2.17.0 #228

merged 1 commit into from
Apr 5, 2021

Conversation

tedt10e
Copy link
Contributor

@tedt10e tedt10e commented Apr 2, 2021

No description provided.

@tedt10e
Copy link
Contributor Author

tedt10e commented Apr 2, 2021

Hi @bensheldon

The new JRuby version I've just added to the matrix is working but the minimum supported JRuby version is not.

Could you kindly check?

Many Thanks.

@tedt10e tedt10e closed this Apr 3, 2021
@tedt10e tedt10e reopened this Apr 3, 2021
@tedt10e
Copy link
Contributor Author

tedt10e commented Apr 3, 2021

I just rerun the checks, and they all passed now.

I'm not sure why it failed before. (maybe heisenbug 😀)

Anyway, it's ready to be merged now.

Thanks 🙏

@bensheldon bensheldon merged commit 91271d9 into bensheldon:main Apr 5, 2021
@bensheldon
Copy link
Owner

@tedhexaflow thanks! The jRuby tests seem slightly flakier than the MRI tests; I wish I knew what the problem was.

@tedt10e tedt10e deleted the gh-test-matrix-jruby-9.2.17.0 branch April 5, 2021 15:51
@bensheldon bensheldon added the dependencies Pull requests that update a dependency file label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants