Refactor deprecated wait parameter and assorted improvements

lib/good_job.rb

@@ -96,13 +96,13 @@ def self.reperform_jobs_on_standard_error=(value)
   # @param wait [Boolean] whether to wait for shutdown
   # @return [void]
   def self.shutdown(timeout: -1, wait: nil)
-    timeout = if wait.present?
+    timeout = if wait.nil?
+                timeout
+              else
                 ActiveSupport::Deprecation.warn(
                   "Using `GoodJob.shutdown` with `wait:` kwarg is deprecated; use `timeout:` kwarg instead e.g. GoodJob.shutdown(timeout: #{wait ? '-1' : 'nil'})"
                 )
                 wait ? -1 : nil
-              else
-                timeout
               end
 
     executables = Array(Notifier.instances) + Array(Poller.instances) + Array(Scheduler.instances)

lib/good_job/adapter.rb

@@ -105,13 +105,13 @@ def enqueue_at(active_job, timestamp)
     # @param wait [Boolean, nil] Deprecated. Use +timeout:+ instead.
     # @return [void]
     def shutdown(timeout: :default, wait: nil)
-      timeout = if wait.present?
+      timeout = if wait.nil?
+                  timeout
+                else
                   ActiveSupport::Deprecation.warn(
                     "Using `GoodJob::Adapter.shutdown` with `wait:` kwarg is deprecated; use `timeout:` kwarg instead e.g. GoodJob::Adapter.shutdown(timeout: #{wait ? '-1' : 'nil'})"
                   )
                   wait ? -1 : nil
-                else
-                  timeout
                 end
 
       timeout = if timeout == :default

lib/good_job/configuration.rb

@@ -84,9 +84,9 @@ def max_threads
     # on the format of this string.
     # @return [String]
     def queue_string
-      options[:queues] ||
-        rails_config[:queues] ||
-        env['GOOD_JOB_QUEUES'] ||
+      options[:queues].presence ||
+        rails_config[:queues].presence ||
+        env['GOOD_JOB_QUEUES'].presence ||
         '*'
     end
 

scripts/benchmark_scheduler.rb

@@ -10,7 +10,7 @@
 MAX_THREADS = 0
 JOBS_SIZE = 20_000
 
-class Performer
+class CustomPerformer < GoodJob::JobPerformer
   def name
     'script'
   end
@@ -28,7 +28,7 @@ def next_at(**_options)
   end
 end
 
-scheduler = GoodJob::Scheduler.new(Performer.new, max_threads: MAX_THREADS, max_cache: MAX_CACHE)
+scheduler = GoodJob::Scheduler.new(CustomPerformer.new("*"), max_threads: MAX_THREADS, max_cache: MAX_CACHE)
 
 report = MemoryProfiler.report do
   JOBS_SIZE.times { scheduler.create_thread({ scheduled_at: Time.current + 100_000 }) }