Use pg_advisory_unlock_all
after each thread's job execution; fix Lockable return values; improve test stability
#285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When under heavy load, as seen in tests, for an indeterminate reason, job records remain advisory locked. Rather than unlocking each record individually, this unlocks all advisory locks for the thread's database session.
Other functional improvements:
void
exists?
would always return true in Ruby even if the function (e.g.pg_advisory_unlock
had a false value in the query)Test Improvements:
TestJob
constant rather than stubbing over existingExampleJob
because JRuby sometimes does not stub properly and it becomes confusing to debugstderr
, e.g. "WARNING: you don't own a lock of type ExclusiveLock"