Wrap and truncate error message, which can be a huge text #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morgoth The CI failure is caused by a change in Rails HEAD. I fixed it (https://github.com/bensheldon/good_job/pull/299/files#diff-ba08e71d597ff998a90c368fd87831444de2625b01a474331cff63482dc420cfR64-R70) and you should be good to rebase this. |
bensheldon
force-pushed
the
displaying-error
branch
from
053df6f
to
c7b09e9
Compare
|
@morgoth I was able to rebase it myself 💪 |
bensheldon
force-pushed
the
displaying-error
branch
from
c7b09e9
to
f9d7ee1
Compare
bensheldon
force-pushed
the
displaying-error
branch
from
f9d7ee1
to
1fd230e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition I'm thinking about dedicated show page, that will display single record with all the details, as with this change it is not possible to see the full error.