Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for race conditions in ActiveJob concurrency extension #326

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fixes for race conditions in ActiveJob concurrency extension #326

merged 1 commit into from
Aug 13, 2021

Conversation

codyrobbins
Copy link
Contributor

Fixes for #325.

bensheldon
bensheldon requested changes Aug 11, 2021
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I left some suggestions for improvement; the primary one issue is ensuring that block.call is not called multiple times.

lib/good_job/active_job_extensions/concurrency.rb Outdated Show resolved Hide resolved
lib/good_job/active_job_extensions/concurrency.rb Outdated Show resolved Hide resolved
@codyrobbins codyrobbins requested a review from bensheldon August 12, 2021 17:51
@codyrobbins codyrobbins requested a review from bensheldon August 13, 2021 15:42
bensheldon
bensheldon approved these changes Aug 13, 2021
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thank you again 🎉

@bensheldon bensheldon merged commit 655aa43 into bensheldon:main Aug 13, 2021
@bensheldon bensheldon added the bug Something isn't working label Aug 13, 2021
@bensheldon
Copy link
Owner

bensheldon commented Aug 13, 2021 •
edited
Loading

Released in v1.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codyrobbins @bensheldon