Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README style/typo fixes: "web server" and possessive "Rails'" #350

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

aried3r
Copy link
Contributor

@aried3r aried3r commented Aug 26, 2021

I think this "f" isn't meant to be there.

I've replaced "webserver" with "web server" everywhere as it seems that's also what Rails and puma use and the README itself also uses "web server" half of the time.

There's an unfinished or unintentional beginning of a markdown link here ([GoodJob.preserve_job_records), but I'm not sure where this should point, if anywhere at all.

`good_job cleanup_preserved_jobs` deletes preserved job records. See [`GoodJob.preserve_job_records` for when this command is useful.

@aried3r aried3r changed the title Remove superfluous "f" in README.md Some README fixes Aug 26, 2021
@bensheldon bensheldon changed the title Some README fixes README style/typo fixes: "web server" and possessive "Rails'" Aug 26, 2021
@bensheldon bensheldon merged commit 236aea2 into bensheldon:main Aug 26, 2021
@bensheldon
Copy link
Owner

@aried3r thank you! 🙌

@aried3r aried3r deleted the patch-1 branch August 26, 2021 15:58
@bensheldon bensheldon added the documentation Improvements or additions to documentation label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants