Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NOW() from Dashboard SQL; fix chart x-axis order left-to-right, old-to-new #355

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Aug 28, 2021

Closes #304.

  • Replaces NOW() with times coming from Ruby in query
  • Fixes chart x-axis to be left-to-right, old-to-new timestamps
  • Replaces x-axis labels with simply times with timestamps rather than full datetimes
  • Slightly improves label visual overflow
  • Increases quantity of seed data generated for fuller chart
  • Removes sourcemap links because sourcemaps are not included

Screen Shot 2021-08-28 at 9 48 33 AM

…ht, old-to-new

- Replaces `NOW()` with times coming from Ruby in query
- Fixes chart x-axis to be left-to-right, old-to-new timestamps
- Replaces x-axis labels with simply times with timestamps rather than full datetimes
- Slightly improves label visual overflow
- Increases quantity of seed data generated for fuller chart
@bensheldon bensheldon temporarily deployed to goodjob-dashboard-chart-rz7den August 28, 2021 16:48 Inactive
@bensheldon bensheldon added the bug Something isn't working label Aug 31, 2021
@bensheldon bensheldon merged commit 936ef93 into main Aug 31, 2021
@bensheldon bensheldon deleted the dashboard-chart-query branch August 31, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content security policy for dashboard; nest shared view partials; problematic NOW() SQL in Dashboard query
1 participant