Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total_limit: option to GoodJob::Concurrency to be inclusive of counting both enqueued and performing jobs #369

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Sep 9, 2021

  • Also edits notice about incompatibility with Rails 5 because throw :abort is not currently used (but still doesn't work in Rails 5 because I can't figure out how to halt an around_ callback)

Connects to #366.

@bensheldon bensheldon temporarily deployed to goodjob-concurrency-inc-x99jti September 9, 2021 03:26 Inactive
@bensheldon bensheldon force-pushed the concurrency_inclusive_limit branch from 658fbf3 to ea5805f Compare September 9, 2021 04:18
@bensheldon bensheldon temporarily deployed to goodjob-concurrency-inc-x99jti September 9, 2021 04:18 Inactive
…counting both enqueued and performing jobs
@bensheldon bensheldon force-pushed the concurrency_inclusive_limit branch from ea5805f to a2d1b45 Compare September 9, 2021 04:24
@bensheldon bensheldon temporarily deployed to goodjob-concurrency-inc-x99jti September 9, 2021 04:24 Inactive
@bensheldon bensheldon added the enhancement New feature or request label Sep 9, 2021
@bensheldon bensheldon merged commit 64f879c into main Sep 9, 2021
@bensheldon bensheldon deleted the concurrency_inclusive_limit branch September 9, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant