Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH Test Matrix with more PG versions #401

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Update GH Test Matrix with more PG versions #401

merged 2 commits into from
Oct 5, 2021

Conversation

tedt10e
Copy link
Contributor

@tedt10e tedt10e commented Oct 5, 2021

No description provided.

@tedt10e
Copy link
Contributor Author

tedt10e commented Oct 5, 2021

Hi @bensheldon

Is it ok having 21 checks? Or should we just keep the two latest versions? (13 and 14)

Should I also remove (ruby 2.7 with pg 10.8) from the matrix?

bensheldon
bensheldon reviewed Oct 5, 2021
View reviewed changes
.github/workflows/test.yml Outdated
Comment on lines 38 to 41
pg: [12, 13, 14]
include:
- ruby: 2.7
pg: 10.8
Copy link
Owner

@bensheldon bensheldon Oct 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the matrix this way would reduce the number of multiplicative options:

Suggested change
pg: [12, 13, 14]
include:
- ruby: 2.7
pg: 10.8
pg: [14]
include:
- ruby: 3.0
pg: 10.8
- ruby: 3.0
pg: 11
- ruby: 3.0
pg: 12
- ruby: 3.0
pg: 13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bensheldon,

I've added 10,11,12,13 also for the latest JRuby.

Hope you are ok with that. Thanks.

@bensheldon bensheldon merged commit f114b97 into bensheldon:main Oct 5, 2021
@bensheldon
Copy link
Owner

Thank you!!

@bensheldon bensheldon added the dependencies Pull requests that update a dependency file label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tedt10e @bensheldon