Explicitly unscope queries within block yielded to Lockable.within_advisory_lock #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
unscope_with_advisory_lock
branch
from
cfa960c
to
41c5728
Compare
bensheldon
force-pushed
the
unscope_with_advisory_lock
branch
from
41c5728
to
7520431
Compare
bensheldon
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL
yieldwithin an ActiveRecord class method will leak query scope into queries on the same model class within the block.Discovered because the demo
CleanupJobwas not working correctly because its queries forGoodJob::Executionwere being improperly scoped.