Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fulltext search filter #440

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add fulltext search filter #440

merged 1 commit into from
Nov 1, 2021

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Oct 29, 2021

Closes #432.

Bit of a spike, but wanted to open up for feedback.

Some quirks:

  • When searching jobs, it only searches the properties of the most recent execution. So while the "Last Error" (i.e. the error from the previous execution) of a job will appear in the dashboard, it's not queryable.
  • There is no search indexing, so this results in a row scan.

@bensheldon bensheldon temporarily deployed to goodjob-search-6jgodddc2xovrhx October 29, 2021 15:29 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-search-6jgodddc2xovrhx October 29, 2021 16:30 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-search-6jgodddc2xovrhx October 30, 2021 23:35 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-search-6jgodddc2xovrhx October 31, 2021 20:29 Inactive
engine/app/views/good_job/shared/_filter.erb Outdated Show resolved Hide resolved
engine/app/views/good_job/shared/_filter.erb Outdated Show resolved Hide resolved
@bensheldon bensheldon temporarily deployed to goodjob-search-6jgodddc2xovrhx November 1, 2021 14:29 Inactive
@bensheldon bensheldon merged commit 0308a29 into main Nov 1, 2021
@bensheldon bensheldon deleted the search branch November 1, 2021 16:50
@bensheldon bensheldon added the enhancement New feature or request label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a search bar to Dashboard
2 participants