Add arbitrary lock on class level too

[pandwoter]

#341

[bensheldon]

@pandwoter This is a great start.

I noticed that you created a new method called .with_advisory_record_lock. I'd like the key: parameter added to the existing .with_advisory_lock class method. e.g. "it can be passed a column or a key" It's going to arguably overload it, but I don't want to introduce another method.

And I'm glad that you added additional .advisory_record_lock and advisory_record_unlock methods. I'd like those all to be renamed .advisory_lock so that they are symmetrical with the instance methods.

Also, I think an additional refactor, once the class methods are dialed in, is to have the instance methods delegate to the class methods where possible.

Thank you!

[pandwoter]

I noticed that you created a new method called .with_advisory_record_lock. I'd like the key: parameter added to the existing .with_advisory_lock class method. e.g. "it can be passed a column or a key" It's going to arguably overload it, but I don't want to introduce another method.

Done! ✅

And I'm glad that you added additional .advisory_record_lock and advisory_record_unlock methods. I'd like those all to be renamed .advisory_lock so that they are symmetrical with the instance methods.

Yeah, I named this method like so due that we already have advisory_lock scope and we can't define a method with this exact name 😢 (

good_job/lib/good_job/lockable.rb

Line 40 in 68fb960

scope :advisory_lock, (lambda do |column: _advisory_lockable_column, function: advisory_lockable_function|

)

Also, I think an additional refactor, once the class methods are dialed in, is to have the instance methods delegate to the class methods where possible.

Done ✅

Any thoughts regarding these scopes @bensheldon? To have exact same interface on a class and instance level we need to do something with it...

[bensheldon]

Any thoughts regarding these scopes @bensheldon? To have exact same interface on a class and instance level we need to do something with it...

I think what we have right now is mergable; it accomplishes what I set out. You do surface an issue of there are several methods to overload. I'm thinking:

• create separate class-level *_key and *_column methods e.g. .advisory_lock_key/.advisory_lock_column, and advisory_unlock_key/advisory_unlock_column
• And then create the combined class methods that can take either a column or a key and delegate to the more specific method.

[bensheldon]

🎉