Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard LogSubscriber against tagged logger without a formatter #504

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Guard LogSubscriber against tagged logger without a formatter #504

merged 1 commit into from
Jan 31, 2022

Conversation

bensheldon
Copy link
Owner

SemanticLogger will create a Tagged Logger that does not have a formatter. This guard against that.

See reidmorrison/rails_semantic_logger#29

Closes #502

@bensheldon bensheldon temporarily deployed to goodjob-log-formatter-xfvt86in January 30, 2022 15:59 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-log-formatter-xfvt86in January 30, 2022 16:17 Inactive
@bensheldon bensheldon added the bug Something isn't working label Jan 31, 2022
@bensheldon bensheldon merged commit f02da16 into main Jan 31, 2022
@bensheldon bensheldon deleted the log_formatter branch January 31, 2022 15:38
@bensheldon bensheldon mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all loggers have a formatter
1 participant
@bensheldon