Convert GoodJob into a single mountable engine (instead of a plugin plus optional engine) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
proper_engine
branch
from
087ae73
to
3d16ada
Compare
bensheldon
force-pushed
the
proper_engine
branch
from
3d16ada
to
7ff3003
Compare
bensheldon
force-pushed
the
proper_engine
branch
from
7ff3003
to
4705f2f
Compare
bensheldon
force-pushed
the
proper_engine
branch
from
4705f2f
to
cf51d76
Compare
bensheldon
force-pushed
the
proper_engine
branch
from
cf51d76
to
3ea82b5
Compare
bensheldon
force-pushed
the
proper_engine
branch
4 times, most recently
from
0c394c0
to
e80071a
Compare
bensheldon
added
refactor
…lus optional engine)
bensheldon
force-pushed
the
proper_engine
branch
from
e80071a
to
e619cf9
Compare
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main user-facing change is that the
require 'good_job/engine'will no longer be required to be added to one'sapplication.rb.Update: In my testing (on a production application; and on a starter api-only app), this doesn't require any developer-facing changes, so I'm inclined to ship this as part of the 2.x line rather than wait until 3.0.