Use javascript importmaps for Dashboard #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
modules
branch
4 times, most recently
from
101893c
to
ee89c21
Compare
bensheldon
changed the title
bensheldon
force-pushed
the
modules
branch
16 times, most recently
from
a354f07
to
9e5f1f8
Compare
bkeepers
added a commit
to bkeepers/good_job
that referenced
this pull request
Apr 29, 2022
* origin/main: Release good_job v2.14.1 Temporarily disable Mass Action "Apply to all" because the action is badly scoped (bensheldon#583) Release good_job v2.14.0 Add mass update operations for jobs to Dashboard (bensheldon#578) Track down incompatibility/race condition between JRuby and RSpec mocks in tests (bensheldon#581) Release good_job v2.13.2 Namespaces assets per Rails docs (bensheldon#580) Release good_job v2.13.1 Set up javascript importmaps for Dashboard; refactor Polling (bensheldon#574) Use toasts to show notices and alerts (bensheldon#577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly speculative. I would really like to write modular javascript. The intention is still to avoid dependence on any particular asset pipeline configuration.
tag.scripttags to ensure that script/module paths are only paths and not full urls.; full urls do not work.