Zeitwerk ignore lib/active_job
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ActiveJob load; move Railtie framework on_loads out of `after_initialize`
bensheldon
changed the title
lib/active_job and explicitly require adapter after ActiveJob load; move Railtie framework on_loads out of after_initializelib/active_job
bensheldon
force-pushed
the
require_active_job_adapter
branch
from
8532b27
to
038890d
Compare
bensheldon
force-pushed
the
require_active_job_adapter
branch
from
038890d
to
2a3754c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #616.
Moving theon_loads out ofafter_initializeis slightly risky as a change to #483, but I am not sure if the previous configuration was strictly necessary and I think un-nesting them is clearer.