Fix :inline mode with future behavior to run unscheduled jobs immediately
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
commented
Jun 18, 2022
| @@ -65,7 +65,7 @@ def enqueue_at(active_job, timestamp) | |||
| scheduled_at = timestamp ? Time.zone.at(timestamp) : nil | |||
|
|
|||
| if execute_inline? | |||
| future_scheduled = (scheduled_at.nil? || scheduled_at > Time.current) | |||
| future_scheduled = scheduled_at && scheduled_at > Time.current | |||
bensheldon
force-pushed
the
cleanup_deprecations
branch
from
c2c1e73
to
91041d3
Compare
…n messages in test suite
bensheldon
force-pushed
the
cleanup_deprecations
branch
from
91041d3
to
b12ee12
Compare
bensheldon
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses the inline deprecations in the test suite.