Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Configuration.total_estimated_threads to report number of threads consumed by GoodJob #645

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add Configuration.total_estimated_threads to report number of threads consumed by GoodJob #645

merged 1 commit into from
Aug 5, 2022

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Jun 26, 2022 •
edited
Loading

  • Rename to total_estimated_threads
  • When running async, also warn when the sum of goodjob and puma threads exceed the pool
  • Fix the tests

@bensheldon bensheldon temporarily deployed to goodjob-total-threads-dudd17ki June 26, 2022 20:13 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-total-threads-dudd17ki June 26, 2022 20:14 Inactive
@bensheldon bensheldon changed the title Add Configuration.total_threads to report number of threads consumed by GoodJob Add Configuration.total_estimated_threads to report number of threads consumed by GoodJob Jul 19, 2022
@bensheldon bensheldon force-pushed the total_threads branch 2 times, most recently from e9ea82a to c23b2f3 Compare August 5, 2022 22:11
@bensheldon bensheldon marked this pull request as ready for review August 5, 2022 22:41
@bensheldon bensheldon merged commit 3fbb8a5 into main Aug 5, 2022
@bensheldon bensheldon deleted the total_threads branch August 5, 2022 22:41
@bensheldon bensheldon added the enhancement New feature or request label Aug 5, 2022
@bensheldon bensheldon mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bensheldon