Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "timestamp" column-type in migrations with "datetime" #671

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Replace "timestamp" column-type in migrations with "datetime" #671

merged 1 commit into from
Jul 20, 2022

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Jul 20, 2022 •
edited
Loading

Connects to #668.

My understanding is that datetime is the generic column type, that the database adapter will then convert into its own appropriate type (timestamp or timestamptz)

@bensheldon bensheldon temporarily deployed to goodjob-migration-datet-fawjwk July 20, 2022 15:17 Inactive
@bensheldon bensheldon marked this pull request as ready for review July 20, 2022 15:37
@bensheldon bensheldon merged commit 2d50454 into main Jul 20, 2022
@bensheldon bensheldon deleted the migration_datetime branch July 20, 2022 15:37
@bensheldon bensheldon added the bug Something isn't working label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bensheldon