Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep locale param when submitting dashboard filter #707

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

aki77
Copy link
Contributor

@aki77 aki77 commented Aug 20, 2022

Behavior before modification

@bensheldon bensheldon changed the title fix: Keep locale param Keep locale param when submitting dashboard filter Aug 20, 2022
@bensheldon bensheldon added the bug Something isn't working label Aug 20, 2022
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! 🙌🏻

btw, what are you using to see the DOM changes highlighted in red?

@bensheldon bensheldon merged commit 66a7a56 into bensheldon:main Aug 20, 2022
@bensheldon
Copy link
Owner

Released: https://github.com/bensheldon/good_job/releases/tag/v3.4.4

@aki77 aki77 deleted the keep-locale-param branch August 20, 2022 22:00
@aki77
Copy link
Contributor Author

aki77 commented Aug 20, 2022

Thanks!
The DOM highlighting is due to the following changes. (translation_missing style)
2b584df

Whenever good_job is used from a language other than the one provided by default, it is always highlighted.
If highlighting is for good_job developers, I think it would be better if only developers explicitly enable highlighting.

@bensheldon
Copy link
Owner

@aki77 oh 🤦🏻 I had forgotten that's GoodJob code. Yes, that highlight should be removed; the intent was to help with internationalizing GoodJob, but I wasn't thinking about the side effects.

I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants