Rename Job status of finished to succeeded; finished now means either succeeded or discarded
#721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
rename-finished-succeeded
branch
from
3705d50
to
0bdb760
Compare
…either `succeeded` or `discarded`
bensheldon
force-pushed
the
rename-finished-succeeded
branch
from
0bdb760
to
e94edb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns status names with #712.
Previously, a job was either
finishedordiscarded.Now, a job is
finished, which can be eithersucceeded(run fully once without error) ordiscarded(errored and was not retried)