Redo: When not preserving job records, ensure all prior executions are deleted after successful retry #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e deleted after successful retry" This reverts commit e44b354.
bensheldon
commented
Oct 22, 2022
| @@ -296,13 +297,14 @@ def perform | |||
| job_error = result.handled_error || result.unhandled_error | |||
| self.error = [job_error.class, ERROR_MESSAGE_SEPARATOR, job_error.message].join if job_error | |||
|
|
|||
| reenqueued = result.retried? || retried_good_job_id.present? | |||
There was a problem hiding this comment.
This is the significant change in this PR from the previously reverted PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes the reversion of #719 in #729, informed by #728.
Newly, this covers the case when
ActiveJob::Base#reenqueueis called directly during job execution (not viaretry_job), which I had not considered initially.