Redirect to Jobs path after destroy #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when a job is deleted the controller redirects back to that job page which throws not found error. This PR redirects back to the jobs index page which is the expected behaviour.
bensheldon
approved these changes
Dec 3, 2022
|
I made a PR to rubocop-rails: rubocop/rubocop-rails#880 |
bensheldon
reviewed
Dec 3, 2022
Co-authored-by: Ben Sheldon [he/him] <bensheldon@github.com>
ah! right. Thanks for helping me with this. I'm in love with this gem ❤️ |
|
@BilalBudhani thank you again! Released: https://github.com/bensheldon/good_job/releases/tag/v3.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a job is deleted the controller redirects back to that job page which throws not found error.
This PR redirects back to the jobs index page which is the expected behaviour.