Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rubocop from 1.39.0 to 1.40.0 #769

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Bump rubocop from 1.39.0 to 1.40.0 #769

merged 2 commits into from
Dec 12, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2022

Bumps rubocop from 1.39.0 to 1.40.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.40

New features

Bug fixes

  • #5251: Fix loading of configuration in multi-file edge case. (@​NobodysNightmare)
  • #11192: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using a block argument. (@​ydah)
  • #11143: Fix RedundantCopDisableDirective errors when encountering several department comments. (@​isarcasm)
  • #11230: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with [] operator followed by method chain. (@​koic)
  • #11181: Fix pattern to match .tool-versions files that specify multiple runtimes. (@​noelblaschke)
  • #11239: Fix an incorrect autocorrect for Style/GuardClause when using heredoc as an argument of raise in branch body. (@​koic)
  • #11182: Fix an incorrect autocorrect for EnforcedShorthandSyntax: always of Style/HashSyntax with Style/IfUnlessModifier when using Ruby 3.1. (@​koic)
  • #11184: Fix an error for Lint/ShadowingOuterLocalVariable when a block local variable has same name as an outer until scope variable. (@​koic)
  • #11198: Fix an error for Lint/EmptyConditionalBody when one using line if/;/end without then boby. (@​koic)
  • #11196: Fix a false positive for Style/GuardClause when using raise in then body of if..elsif..end form. (@​koic)
  • #11213: Support redundant department disable in scope of Lint/RedundantCopDisableDirective cop. (@​isarcasm)
  • #11200: Fix an incorrect autocorrect for Layout/MultilineMethodCallBraceLayout when using method chain for heredoc argument in multiline literal brace layout. (@​koic)
  • #11190: Fix an error for Style/IfWithSemicolon when using one line if/;/end without then boby. (@​koic)
  • #11244: Fix a false negative for Style/RedundantReturn when dynamic define methods. (@​ydah)

Changes

  • #11218: Update severity of Bundler/DuplicatedGem, Bundler/InsecureProtocolSource, Gemspec/DeprecatedAttributeAssignment, Gemspec/DuplicatedAssignment, Gemspec/RequireMFA, Gemspec/RequiredRubyVersion, and Gemspec/RubyVersionGlobalsUsage cops to warning. (@​koic)
  • #11222: Make Style/RedundantArgument aware of Array#sum. (@​koic)
  • #11070: Add ability to count method calls as one line to code length related Metric cops. (@​fatkodima)
  • #11226: Make Lint/Void aware of used lambda and proc in void context. (@​koic)
  • #11206: Change Lint/InterpolationCheck from Safe: false to SafeAutoCorrect: false. (@​r7kamura)
  • #11212: Make Lint/DeprecatedConstants aware of deprecated Struct::Group and Struct::Passwd classes. (@​koic)
  • #11236: Remove respond_to from default value of AllowedMethods for Style/SymbolProc. (@​koic)
  • #11185: Make Style/HashSyntax aware of without parentheses call expr follows. (@​koic)
  • #11203: Support multiple arguments on Lint/SendWithMixinArgument. (@​r7kamura)
  • #11229: Add cc to AllowedNames of MethodParameterName cop. (@​tjschuck)
  • #11116: Handle ternaries in Style/SafeNavigation. (@​fatkodima)
Changelog

Sourced from rubocop's changelog.

1.40.0 (2022-12-08)

New features

  • #11179: Add Style/RedundantConstantBase cop. ([@​r7kamura][])
  • #11205: Add --[no-]auto-gen-enforced-style CLI option. ([@​ydah][])
  • #11235: Add Style/RequireOrder cop. ([@​r7kamura][])
  • #11219: Make Style/SelectByRegexp aware of !~ method. ([@​koic][])
  • #11224: Add new cop Style/ArrayIntersect which replaces (array1 & array2).any? with array1.intersect?(array2), method Array#intersect? was added in ruby 3.1. ([@​KirIgor][])
  • #11211: Add autocorrect for Lint/AssignmentInCondition. ([@​r7kamura][])

Bug fixes

  • #5251: Fix loading of configuration in multi-file edge case. ([@​NobodysNightmare][])
  • #11192: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using a block argument. ([@​ydah][])
  • #11143: Fix RedundantCopDisableDirective errors when encountering several department comments. ([@​isarcasm][])
  • #11230: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with [] operator followed by method chain. ([@​koic][])
  • #11181: Fix pattern to match .tool-versions files that specify multiple runtimes. ([@​noelblaschke][])
  • #11239: Fix an incorrect autocorrect for Style/GuardClause when using heredoc as an argument of raise in branch body. ([@​koic][])
  • #11182: Fix an incorrect autocorrect for EnforcedShorthandSyntax: always of Style/HashSyntax with Style/IfUnlessModifier when using Ruby 3.1. ([@​koic][])
  • #11184: Fix an error for Lint/ShadowingOuterLocalVariable when a block local variable has same name as an outer until scope variable. ([@​koic][])
  • #11198: Fix an error for Lint/EmptyConditionalBody when one using line if/;/end without then boby. ([@​koic][])
  • #11196: Fix a false positive for Style/GuardClause when using raise in then body of if..elsif..end form. ([@​koic][])
  • #11213: Support redundant department disable in scope of Lint/RedundantCopDisableDirective cop. ([@​isarcasm][])
  • #11200: Fix an incorrect autocorrect for Layout/MultilineMethodCallBraceLayout when using method chain for heredoc argument in multiline literal brace layout. ([@​koic][])
  • #11190: Fix an error for Style/IfWithSemicolon when using one line if/;/end without then boby. ([@​koic][])
  • #11244: Fix a false negative for Style/RedundantReturn when dynamic define methods. ([@​ydah][])

Changes

  • #11218: Update severity of Bundler/DuplicatedGem, Bundler/InsecureProtocolSource, Gemspec/DeprecatedAttributeAssignment, Gemspec/DuplicatedAssignment, Gemspec/RequireMFA, Gemspec/RequiredRubyVersion, and Gemspec/RubyVersionGlobalsUsage cops to warning. ([@​koic][])
  • #11222: Make Style/RedundantArgument aware of Array#sum. ([@​koic][])
  • #11070: Add ability to count method calls as one line to code length related Metric cops. ([@​fatkodima][])
  • #11226: Make Lint/Void aware of used lambda and proc in void context. ([@​koic][])
  • #11206: Change Lint/InterpolationCheck from Safe: false to SafeAutoCorrect: false. ([@​r7kamura][])
  • #11212: Make Lint/DeprecatedConstants aware of deprecated Struct::Group and Struct::Passwd classes. ([@​koic][])
  • #11236: Remove respond_to from default value of AllowedMethods for Style/SymbolProc. ([@​koic][])
  • #11185: Make Style/HashSyntax aware of without parentheses call expr follows. ([@​koic][])
  • #11203: Support multiple arguments on Lint/SendWithMixinArgument. ([@​r7kamura][])
  • #11229: Add cc to AllowedNames of MethodParameterName cop. ([@​tjschuck][])
  • #11116: Handle ternaries in Style/SafeNavigation. ([@​fatkodima][])
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump rubocop from 1.39.0 to 1.40.0
e15a24f 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.39.0 to 1.40.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.39.0...v1.40.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 12, 2022
@bensheldon bensheldon temporarily deployed to goodjob-dependabot-bund-fgiinb December 12, 2022 10:01 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-dependabot-bund-fgiinb December 12, 2022 16:02 Inactive
@bensheldon bensheldon merged commit 39d7e8b into main Dec 12, 2022
@bensheldon bensheldon deleted the dependabot/bundler/rubocop-1.40.0 branch December 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bensheldon