Ensure that anytime the Notifier uses autoloaded constants (ActiveRecord), they are wrapped with a Rails Executor #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
notifier-executor
branch
from
fb3e386
to
18ac2a3
Compare
bensheldon
force-pushed
the
notifier-executor
branch
from
18ac2a3
to
6251266
Compare
…ord), they are wrapped with a Rails Executor
bensheldon
force-pushed
the
notifier-executor
branch
from
6251266
to
19ee823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #796, #144, #97.
Also removes
ActiveSupport::Dependencies.interlock.permit_concurrent_loadsbecause I believe that is only functional when it is within an Executor wrap, and in this case, it is not.