Create ActiveJob extension to disable sending a NOTIFY on enqueue and retry #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
Comment on lines
9
to
11
| # class MyJob < ApplicationJob | ||
| # include GoodJob::ActiveJobExtensions::Notify | ||
| # end |
There was a problem hiding this comment.
Does this mean if I don't include it, that'll be sufficient to not notify? Is this considered a breaking change?
There was a problem hiding this comment.
No, this is more like "enabled by default, include this extension to change the default value to something else"
hmm, that does make me wonder if I should change it to NotifyConfiguration or something.
bensheldon
force-pushed
the
notify_extension
branch
from
ec6c361 to
f17a081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #810 at more granular level.