Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Matrix: Use Ruby 3.2 to test against all Postgres versions; add PG 15, remove PG 10 #828

Merged
merged 3 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
DISABLE_SPRING: 1
services:
postgres:
image: postgres:14
image: postgres:15
env:
POSTGRES_USER: good_job
POSTGRES_DB: good_job_test
Expand Down Expand Up @@ -77,24 +77,24 @@ jobs:
strategy:
matrix:
ruby: [2.6, 2.7, "3.0", 3.1, 3.2, jruby-9.3]
pg: [14]
pg: [15]
include:
- ruby: "3.0"
pg: 10
- ruby: "3.0"
- ruby: 3.2
pg: 11
- ruby: "3.0"
- ruby: 3.2
pg: 12
- ruby: "3.0"
- ruby: 3.2
pg: 13
- ruby: jruby-9.3
pg: 10
- ruby: 3.2
pg: 14
- ruby: jruby-9.3
pg: 11
- ruby: jruby-9.3
pg: 12
- ruby: jruby-9.3
pg: 13
- ruby: jruby-9.3
pg: 14
env:
PGHOST: localhost
PGUSER: good_job
Expand Down
14 changes: 14 additions & 0 deletions spec/lib/good_job/adapter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,20 @@ def perform
context 'when execution mode async_server' do
let(:adapter) { described_class.new(execution_mode: :async_server) }

before do
scheduler = instance_double(GoodJob::Scheduler)
allow(GoodJob::Scheduler).to receive(:new).and_return(scheduler)

notifier = instance_double(GoodJob::Notifier, recipients: [])
allow(GoodJob::Notifier).to receive(:new).and_return(notifier)

poller = instance_double(GoodJob::Poller, recipients: [])
allow(GoodJob::Poller).to receive(:new).and_return(poller)

cron_manager = instance_double(GoodJob::CronManager)
allow(GoodJob::CronManager).to receive(:new).and_return(cron_manager)
end

context 'when Rails::Server is defined' do
before do
stub_const("Rails::Server", Class.new)
Expand Down