Use GoodJob.capsule in CLI instead of creating a new Capsule
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
added a commit
that referenced
this pull request
Apr 11, 2023
* Bump rails from 7.0.4.2 to 7.0.4.3 (#904) Bumps [rails](https://github.com/rails/rails) from 7.0.4.2 to 7.0.4.3. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.0.4.2...v7.0.4.3) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump selenium-webdriver from 4.8.1 to 4.8.6 (#905) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.8.1 to 4.8.6. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump benchmark-ips from 2.11.0 to 2.12.0 (#907) Bumps [benchmark-ips](https://github.com/evanphx/benchmark-ips) from 2.11.0 to 2.12.0. - [Release notes](https://github.com/evanphx/benchmark-ips/releases) - [Changelog](https://github.com/evanphx/benchmark-ips/blob/master/History.md) - [Commits](evanphx/benchmark-ips@v2.11.0...v2.12.0) --- updated-dependencies: - dependency-name: benchmark-ips dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: locales for de (#903) Co-authored-by: Eric <eric@wtfoxtrot.de> * Add translate_hash to handle missing translation keys that return hashes; only show translatable/available locales in dropdown (#891) * Update README.md (#902) * Add `translate_hash` to handle missing translation keys that return hashes; only show translatable/available locales in dropdown --------- Co-authored-by: Anton Nefedenkov <ain2108@columbia.edu> * Extract more Dashboard strings into localization strings (#899) * improve translations * more translations * fix translation (fixes test) * added missing i18n strings * Translate all languages * Update DE translation * Fix missing key * empty commit * Fix missing UA string --------- Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com> * Extract shared methods/scopes into a BaseExecution to share between Execution and Job models; remove deprecated ActiveJobJob model (#894) * Release good_job v3.15.0 * Switches from Chrome to Chromium to support Apple M1/Arm CPUs (#910) * Remove mention of `Batch.add` method that doesn't exist * Fix lint: missing fr and nl translations; readme whitespace (#914) * Fix missing fr and nl translations * Fix whitespace in Readme * Use `GoodJob.capsule` in CLI instead of creating a new Capsule (#916) * Set `successfully_enqueued?` when using `perform_all_later` (#917) * In tests, directly use `connection.truncate_tables` instead of `ActiveRecord::Tasks::DatabaseTasks.truncate_all` (#918) * Bump erb_lint from 0.3.1 to 0.4.0 Bumps [erb_lint](https://github.com/Shopify/erb-lint) from 0.3.1 to 0.4.0. - [Release notes](https://github.com/Shopify/erb-lint/releases) - [Commits](Shopify/erb_lint@v0.3.1...v0.4.0) --- updated-dependencies: - dependency-name: erb_lint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: eric-christian <298704+eric-christian@users.noreply.github.com> Co-authored-by: Eric <eric@wtfoxtrot.de> Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com> Co-authored-by: Anton Nefedenkov <ain2108@columbia.edu> Co-authored-by: Patricio Mac Adden <patriciomacadden@gmail.com> Co-authored-by: Chris Kelly <ckdake@ckdake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good improvement. I think that extra capsules lingering around may have been a contributor to #849.
Remembering when I previously implemented Capsule, I think I believed that it would be necessary to create the separate, self-contained capsule in the CLI because the
GoodJob.capsulewould not be started/running (because the CLI always runs in:external) mode. But now I realize I can simply explicitly start the capsule 🤷🏻