Fix CI: Lock traces version for Ruby 2.6 compatible version #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
bensheldon
force-pushed
the
fix_ci
branch
3 times, most recently
from
0f14acb
to
e9fb776
Compare
Earlopain
added a commit
to Earlopain/good_job
that referenced
this pull request
Oct 10, 2024
It was initially added in bensheldon#987 but the reasoning is lost on me. Rails 6.1 and 7.0 only work with Rack 2 which causes dependabot update PRs to break CI when it bumps to Rack 3 Rails head will also switch to be Rack 3 only at some point. Just let bundler resolve to what works. GoodJob does have to do some version-specific rack handling but I don't think this needs to be part of the matrix
bensheldon
pushed a commit
that referenced
this pull request
Oct 10, 2024
It was initially added in #987 but the reasoning is lost on me. Rails 6.1 and 7.0 only work with Rack 2 which causes dependabot update PRs to break CI when it bumps to Rack 3 Rails head will also switch to be Rack 3 only at some point. Just let bundler resolve to what works. GoodJob does have to do some version-specific rack handling but I don't think this needs to be part of the matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to socketry/traces#10