-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created beacon config template, added bentoctl tool to copy files for beacon, katsu #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, should this also be done for beacon_cohort.json
while we are here @gsfk ?
Yes, good catch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I guess the intended command for beacon is
./bentoctl.bash init-config beacon
and simiilarly for katsu. This should be in the README somewhere. I wonder also if there's a use case for just ./bentoctl.bash init-config
that does katsu and beacon together. I guess this will come anyway when we manage to unify the config files.
Otherwise this looks great, everything works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
To not deal with permission issues when creating the folder
etc/templates/beacon
as templateslib/beacon/beacon_config.json
&becaon_cohort.json
are git ignored