Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created beacon config template, added bentoctl tool to copy files for beacon, katsu #234

Merged
merged 13 commits into from
May 10, 2024

Conversation

SanjeevLakhwani
Copy link
Contributor

@SanjeevLakhwani SanjeevLakhwani commented Apr 29, 2024

  • beacon config & cohort moved to etc/templates/beacon as templates
  • lib/beacon/beacon_config.json & becaon_cohort.json are git ignored
  • added cli tool init-config service for beacon and katsu to copy the example configs to their respective locations

@SanjeevLakhwani SanjeevLakhwani self-assigned this Apr 29, 2024
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should this also be done for beacon_cohort.json while we are here @gsfk ?

@gsfk
Copy link
Member

gsfk commented Apr 29, 2024

Looks good, should this also be done for beacon_cohort.json while we are here @gsfk ?

Yes, good catch, beacon_cohort.json should be handled in the same way. Hopefully soon we can eliminate this file entirely.

Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I guess the intended command for beacon is

./bentoctl.bash init-config beacon

and simiilarly for katsu. This should be in the README somewhere. I wonder also if there's a use case for just ./bentoctl.bash init-config that does katsu and beacon together. I guess this will come anyway when we manage to unify the config files.

Otherwise this looks great, everything works as expected.

py_bentoctl/other_helpers.py Outdated Show resolved Hide resolved
py_bentoctl/other_helpers.py Outdated Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk
Copy link
Member

gsfk commented May 6, 2024

./bentoctl.bash init-config beacon gives me permission denied error, since config directory was created by root. Possibly easier to just recreate the directory in the repo.

To not deal with permission issues when creating the folder
@SanjeevLakhwani SanjeevLakhwani merged commit f6eb869 into releases/v16 May 10, 2024
4 checks passed
@SanjeevLakhwani SanjeevLakhwani deleted the ignore-beacon-config branch June 17, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants