Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public loading #243

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Fix public loading #243

merged 4 commits into from
Jun 17, 2024

Conversation

SanjeevLakhwani
Copy link
Contributor

  • Previously a solution was made to fix the about files not being found in dev
  • Now the solution is more broad spectrumed and syns all public files as a similar issue was encountered with branding

@SanjeevLakhwani SanjeevLakhwani requested a review from gsfk June 12, 2024 17:05
@SanjeevLakhwani SanjeevLakhwani changed the base branch from main to releases/v16 June 12, 2024 17:06
gsfk
gsfk requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working for me:

bentov2-public  |  /bento-public/bento-public/src/public/assets/bento.svg doesn't exist

@SanjeevLakhwani SanjeevLakhwani requested a review from gsfk June 17, 2024 14:59
gsfk
gsfk requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a fix for container path for branding, haven't tried translations yet

docker-compose.local.yaml Outdated Show resolved Hide resolved
@SanjeevLakhwani SanjeevLakhwani requested a review from gsfk June 17, 2024 15:45
@SanjeevLakhwani SanjeevLakhwani merged commit 0110de2 into releases/v16 Jun 17, 2024
2 checks passed
@SanjeevLakhwani SanjeevLakhwani deleted the fix-public-loading branch June 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjeevLakhwani @gsfk