Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov github actions #393

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Codecov github actions #393

merged 2 commits into from
Apr 18, 2023

Conversation

v-rocheleau
Copy link
Contributor

Codecov's pypi package was deprecated last week.

This PR removes the dependency on the old codecov python package, and replaces it with a Github Action step.

@v-rocheleau v-rocheleau marked this pull request as ready for review April 17, 2023 16:45
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #393 (f3adce7) into develop (a70388d) will not change coverage.
The diff coverage is n/a.

❗ Current head f3adce7 differs from pull request most recent head 709d01b. Consider uploading reports for the commit 709d01b to get more accurate results

@@           Coverage Diff            @@
##           develop     #393   +/-   ##
========================================
  Coverage    85.43%   85.43%           
========================================
  Files          127      127           
  Lines         4869     4869           
  Branches       651      651           
========================================
  Hits          4160     4160           
+ Misses         536      535    -1     
- Partials       173      174    +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyproject.toml Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v-rocheleau v-rocheleau merged commit 5f90e70 into develop Apr 18, 2023
@davidlougheed davidlougheed deleted the fixes/codecov branch May 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants